fix: propagate parent span to spawned ObjectWriter tasks#3609
Merged
albertlockett merged 1 commit intomainfrom Mar 26, 2025
Merged
fix: propagate parent span to spawned ObjectWriter tasks#3609albertlockett merged 1 commit intomainfrom
albertlockett merged 1 commit intomainfrom
Conversation
rpgreen
approved these changes
Mar 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3609 +/- ##
==========================================
+ Coverage 78.67% 78.69% +0.01%
==========================================
Files 258 258
Lines 96817 96823 +6
Branches 96817 96823 +6
==========================================
+ Hits 76172 76196 +24
+ Misses 17578 17559 -19
- Partials 3067 3068 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jay-ju
pushed a commit
to Jay-ju/lance
that referenced
this pull request
Mar 28, 2025
…t#3609) Propagate the parent span context to tasks spawned by ObjectWriter's AsyncWrite implementation. This is needed for callers might have tracing subscribers they're using for observability over write events, and without accurately having the span context propagated, tracing events that happen inside the spawned task are difficult to associate with the invoking write call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate the parent span context to tasks spawned by ObjectWriter's AsyncWrite implementation. This is needed for callers might have tracing subscribers they're using for observability over write events, and without accurately having the span context propagated, tracing events that happen inside the spawned task are difficult to associate with the invoking write call.