feat: add support for fixed size binary to btree#3613
Merged
westonpace merged 3 commits intolance-format:mainfrom Mar 27, 2025
Merged
feat: add support for fixed size binary to btree#3613westonpace merged 3 commits intolance-format:mainfrom
westonpace merged 3 commits intolance-format:mainfrom
Conversation
BubbleCal
approved these changes
Mar 27, 2025
| "0x32333435323334353233343532333435, " | ||
| "'FixedSizeBinary(16)')" | ||
| ) | ||
| ).analyze_plan() |
Contributor
There was a problem hiding this comment.
can we run the query and assert the result is correct?
Member
Author
There was a problem hiding this comment.
Oops, yes. I need to finish this test.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3613 +/- ##
=======================================
Coverage 78.71% 78.71%
=======================================
Files 258 259 +1
Lines 96900 96965 +65
Branches 96900 96965 +65
=======================================
+ Hits 76271 76324 +53
- Misses 17556 17568 +12
Partials 3073 3073
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jay-ju
pushed a commit
to Jay-ju/lance
that referenced
this pull request
Mar 28, 2025
This PR also allows NANs to exist in the btree column
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also allows NANs to exist in the btree column