feat!: refactor Dataset#config api and expose it via pylance#4041
Merged
yanghua merged 9 commits intolance-format:mainfrom Jun 25, 2025
Merged
feat!: refactor Dataset#config api and expose it via pylance#4041yanghua merged 9 commits intolance-format:mainfrom
yanghua merged 9 commits intolance-format:mainfrom
Conversation
majin1102
requested changes
Jun 19, 2025
6741aff to
15c00f8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4041 +/- ##
=======================================
Coverage 79.18% 79.18%
=======================================
Files 300 300
Lines 114101 114101
Branches 114101 114101
=======================================
+ Hits 90347 90350 +3
+ Misses 20272 20270 -2
+ Partials 3482 3481 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
cc @jackye1995 , marked the PR as ready for review |
jackye1995
reviewed
Jun 20, 2025
Contributor
|
Any update on this? |
6bc560f to
268b98c
Compare
268b98c to
5236468
Compare
jackye1995
approved these changes
Jun 25, 2025
Contributor
jackye1995
left a comment
There was a problem hiding this comment.
Looks good to me, pending CI passing. Also the current description seems empty, we should describe the breaking change.
Collaborator
Author
@jackye1995 The breaking change policy failed. Shall we update the version? Or just ignore? |
Contributor
|
Yeah if you are the first author to do breaking change after the last release, then you need to do the version bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: the config API's signature from:
To