feat!: disable auto-cleanup by default#4118
Closed
wjones127 wants to merge 2 commits intolance-format:mainfrom
Closed
feat!: disable auto-cleanup by default#4118wjones127 wants to merge 2 commits intolance-format:mainfrom
wjones127 wants to merge 2 commits intolance-format:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4118 +/- ##
==========================================
- Coverage 78.68% 77.99% -0.70%
==========================================
Files 285 301 +16
Lines 113527 102889 -10638
Branches 113527 102889 -10638
==========================================
- Hits 89328 80247 -9081
+ Misses 20772 19685 -1087
+ Partials 3427 2957 -470
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes WriteParams default to set auto_cleanup: None instead of Some(AutoCleanupParams::default()). This addresses community feedback that auto-cleanup should be an opt-in feature rather than enabled by default. Changes: - WriteParams::default() now sets auto_cleanup to None - Updated auto_cleanup_old_versions test to explicitly enable auto-cleanup - Added test to verify auto-cleanup is disabled by default - Enhanced MockDatasetFixture to support auto-cleanup configuration Fixes lance-format#3854 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1a26cfe to
d04d8a0
Compare
Contributor
|
Thank you for your contribution. This PR has been inactive for a while, so we're closing it to free up bandwidth. Feel free to reopen it if you still find it useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: disables auto-cleanup by default.
Summary
Changes WriteParams default to disable auto-cleanup by default, addressing community feedback in issue #3854.
Changes Made
auto_cleanup: Noneinstead ofSome(AutoCleanupParams::default())auto_cleanup_old_versionstest to explicitly enable auto-cleanup since it no longer works with default paramstest_auto_cleanup_default_disabled()verifies the new default behaviorBreaking Change Context
Auto-cleanup was previously enabled by default (PR #3572), but community feedback indicated this was unexpected behavior:
Test Results
API Impact
WriteParams::default()now hasauto_cleanup: Noneauto_cleanup_options: NoneUsers who want auto-cleanup can now explicitly opt-in by:
Fixes #3854
🤖 Generated with Claude Code