ci: polish workflow by reduce cache size and remove not needed actions#4139
Merged
Xuanwo merged 3 commits intolance-format:mainfrom Aug 7, 2025
Merged
ci: polish workflow by reduce cache size and remove not needed actions#4139Xuanwo merged 3 commits intolance-format:mainfrom
Xuanwo merged 3 commits intolance-format:mainfrom
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4139 +/- ##
==========================================
+ Coverage 80.59% 81.74% +1.15%
==========================================
Files 301 301
Lines 108249 121661 +13412
Branches 108249 121661 +13412
==========================================
+ Hits 87238 99447 +12209
- Misses 17899 18458 +559
- Partials 3112 3756 +644
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jackye1995
reviewed
Jul 4, 2025
jackye1995
approved these changes
Jul 4, 2025
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
apart from the question, looks good to me
westonpace
reviewed
Jul 4, 2025
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
I think cache-targets: false and cache-workspace-crates: false is good. But why remove setup-rust-toolchain?
wjones127
added a commit
that referenced
this pull request
Nov 14, 2025
…#5236) In #4139, we stopped caching built dependencies. Since then, we've had to wait 20 minutes for the test to build, before we even run any tests. This PR re-enables the build cache and implements a different mitigation to avoid large caches: we disable debug info in dependencies and only keep it in our crates. This is inspired by DataFusion's CI: https://github.com/apache/datafusion/blob/377c0fce481d561d58e3a6fad2dca18cb1d58384/Cargo.toml#L247-L259 Below are the reductions in size of the target directory. Previously, Rust jobs were running with `debuginfo=1`, so the target directory was about 16GB. With these changes, it's down to 7.6GB. If we decided later we wanted it even smaller, we could enable `-C opt-level=s`, which gets us down to 2.1GB. | Profile | Flags | `target/` size | % reduction | |--------|--------|-------:|------:| | dev | | 25.0GB | - | | dev | `-C debuginfo=1` | 16.0GB | 36% | | dev | `-C debuginfo=line-tables-only` | 12.0GB | 52% | | ci | | 7.6GB | 70% | | ci | `-C opt-level=s` | 2.1GB | 92% | Other optimizations added: * Removed `CARGO_BUILD_JOBS`, which was preventing parallelism in builds. We can add this back to specific runners if we find it's necessary. This will speed up cold builds. * Align profile across all builds in CI. Thanks to reduction in disk space, closes #5218. ### Performance improvement Most of the speed improvement probably comes from removing `CARGO_BUILD_JOBS`. Jobs that run tests aren't much faster since the tests take a while. | Case | Before | After (cold) | mul | After (cached) | mul | |--------|-------:|---:|---:|---:|---:| | linux-arm | 38m 58s | 20m 5s | **1.9x** | 18m 33s | **2.1x** | | MSRV Check | 11m 46s | 5m 17s | **2.3x** | 2m 8s | **5.5x** | | Clippy | 13m 16s | 5m 26s | **2.4x** | 2m 25s | **5.4x** |
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…lance-format#5236) In lance-format#4139, we stopped caching built dependencies. Since then, we've had to wait 20 minutes for the test to build, before we even run any tests. This PR re-enables the build cache and implements a different mitigation to avoid large caches: we disable debug info in dependencies and only keep it in our crates. This is inspired by DataFusion's CI: https://github.com/apache/datafusion/blob/377c0fce481d561d58e3a6fad2dca18cb1d58384/Cargo.toml#L247-L259 Below are the reductions in size of the target directory. Previously, Rust jobs were running with `debuginfo=1`, so the target directory was about 16GB. With these changes, it's down to 7.6GB. If we decided later we wanted it even smaller, we could enable `-C opt-level=s`, which gets us down to 2.1GB. | Profile | Flags | `target/` size | % reduction | |--------|--------|-------:|------:| | dev | | 25.0GB | - | | dev | `-C debuginfo=1` | 16.0GB | 36% | | dev | `-C debuginfo=line-tables-only` | 12.0GB | 52% | | ci | | 7.6GB | 70% | | ci | `-C opt-level=s` | 2.1GB | 92% | Other optimizations added: * Removed `CARGO_BUILD_JOBS`, which was preventing parallelism in builds. We can add this back to specific runners if we find it's necessary. This will speed up cold builds. * Align profile across all builds in CI. Thanks to reduction in disk space, closes lance-format#5218. ### Performance improvement Most of the speed improvement probably comes from removing `CARGO_BUILD_JOBS`. Jobs that run tests aren't much faster since the tests take a while. | Case | Before | After (cold) | mul | After (cached) | mul | |--------|-------:|---:|---:|---:|---:| | linux-arm | 38m 58s | 20m 5s | **1.9x** | 18m 33s | **2.1x** | | MSRV Check | 11m 46s | 5m 17s | **2.3x** | 2m 8s | **5.5x** | | Clippy | 13m 16s | 5m 26s | **2.4x** | 2m 25s | **5.4x** |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #4134