Skip to content

feat!: shallow_clone supports index#4553

Merged
jackye1995 merged 17 commits intolance-format:mainfrom
majin1102:shallow_clone_index
Aug 28, 2025
Merged

feat!: shallow_clone supports index#4553
jackye1995 merged 17 commits intolance-format:mainfrom
majin1102:shallow_clone_index

Conversation

@majin1102
Copy link
Copy Markdown
Contributor

Context:

#4257 (comment)

@github-actions github-actions Bot added the enhancement New feature or request label Aug 24, 2025
@majin1102 majin1102 changed the title feat: shallow_clone supports index feat!: shallow_clone supports index Aug 24, 2025
@majin1102 majin1102 marked this pull request as draft August 24, 2025 15:36
@jackye1995 jackye1995 self-requested a review August 25, 2025 15:44
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 86.42298% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.88%. Comparing base (06f8cf9) to head (99d49eb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/index.rs 87.90% 24 Missing and 6 partials ⚠️
rust/lance/src/dataset.rs 50.00% 6 Missing and 2 partials ⚠️
rust/lance/src/index/scalar.rs 54.54% 4 Missing and 1 partial ⚠️
rust/lance/src/io/commit.rs 80.76% 0 Missing and 5 partials ⚠️
rust/lance/src/index/vector.rs 0.00% 3 Missing ⚠️
rust/lance-table/src/format/manifest.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4553      +/-   ##
==========================================
+ Coverage   80.86%   80.88%   +0.02%     
==========================================
  Files         314      314              
  Lines      115127   115468     +341     
  Branches   115127   115468     +341     
==========================================
+ Hits        93098    93401     +303     
- Misses      18745    18769      +24     
- Partials     3284     3298      +14     
Flag Coverage Δ
unittests 80.88% <86.42%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@majin1102 majin1102 marked this pull request as ready for review August 26, 2025 11:48
@majin1102
Copy link
Copy Markdown
Contributor Author

Hi, @jackye1995 I believe this is ready for review

Comment thread rust/lance-table/src/format/manifest.rs
Comment thread rust/lance/src/index/vector/ivf.rs
Comment thread rust/lance/src/index/scalar.rs
@majin1102
Copy link
Copy Markdown
Contributor Author

Have added docs for Manifest.shallow_clone.

Thank you for supplementing the test cases!

Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jackye1995 jackye1995 merged commit e2f08db into lance-format:main Aug 28, 2025
26 checks passed
@majin1102 majin1102 deleted the shallow_clone_index branch September 10, 2025 07:29
jackye1995 added a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
Context:

lance-format#4257 (comment)

---------

Co-authored-by: Jack Ye <yezhaoqin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants