Skip to content

fix(rust): fix rechunk sequences bug and refactor for better readability#4695

Merged
yanghua merged 3 commits intolance-format:mainfrom
yanghua:fix-rechunk-bug
Sep 18, 2025
Merged

fix(rust): fix rechunk sequences bug and refactor for better readability#4695
yanghua merged 3 commits intolance-format:mainfrom
yanghua:fix-rechunk-bug

Conversation

@yanghua
Copy link
Copy Markdown
Collaborator

@yanghua yanghua commented Sep 11, 2025

No description provided.

@github-actions github-actions Bot added the bug Something isn't working label Sep 11, 2025
@yanghua yanghua marked this pull request as ready for review September 11, 2025 11:40
@yanghua yanghua requested a review from wjones127 September 11, 2025 11:41
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 98.01980% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.74%. Comparing base (6657b11) to head (b50536b).
⚠️ Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-table/src/rowids.rs 98.01% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4695      +/-   ##
==========================================
+ Coverage   80.56%   80.74%   +0.17%     
==========================================
  Files         317      321       +4     
  Lines      119295   125705    +6410     
  Branches   119295   125705    +6410     
==========================================
+ Hits        96113   101498    +5385     
- Misses      19729    20607     +878     
- Partials     3453     3600     +147     
Flag Coverage Δ
unittests 80.74% <98.01%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yanghua
Copy link
Copy Markdown
Collaborator Author

yanghua commented Sep 11, 2025

Hi @wjones127 Please take a look when you have time.

Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good to me

Comment thread rust/lance-table/src/rowids.rs Outdated
@yanghua yanghua merged commit 03ef0b9 into lance-format:main Sep 18, 2025
26 checks passed
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants