feat(java): expose additional Operation::Update fields to bindings#4788
Merged
jackye1995 merged 8 commits intolance-format:mainfrom Sep 25, 2025
Merged
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Contributor
Author
|
@jackye1995 @yanghua This pr is ready for review when you have a moment. Thanks! |
jackye1995
approved these changes
Sep 25, 2025
Contributor
jackye1995
left a comment
There was a problem hiding this comment.
Overall looks good to me, pending CI
Contributor
Author
|
@jackye1995 My sincere apologies for the extra commit. I just pushed a fix for a code formatting issue that the CI caught. Would you mind taking another quick look? Thank you very much for the extra review! |
Contributor
|
Thanks for the work!! |
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…ance-format#4788) This PR enhances the Java bindings for Operation::Update as a follow-up to lance-format#4589. While lance-format#4589 introduced new fields to the Rust Operation::Update struct, the Java bindings were still missing support not only for those new fields but also for the existing `fields_modified field`, which is crucial for handling column modifications. Specifically, it adds support for the following fields: ```rust Update { // ... /// The fields that have been modified fields_modified: Vec<u32>, // 👇 New fields from lance-format#4589 /// The fields that used to judge whether to preserve the new frag's id into /// the frag bitmap of the specified indices. fields_for_preserving_frag_bitmap: Vec<u32>, /// The mode of update update_mode: Option<UpdateMode>, } ``` --------- Co-authored-by: Weiren <litaiwei.lwt@antgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the Java bindings for Operation::Update as a follow-up to #4589.
While #4589 introduced new fields to the Rust Operation::Update struct, the Java bindings were still missing support not only for those new fields but also for the existing
fields_modified field, which is crucial for handling column modifications.Specifically, it adds support for the following fields: