Skip to content

feat(java): expose additional Operation::Update fields to bindings#4788

Merged
jackye1995 merged 8 commits intolance-format:mainfrom
wayneli-vt:update-operation-jni-impl
Sep 25, 2025
Merged

feat(java): expose additional Operation::Update fields to bindings#4788
jackye1995 merged 8 commits intolance-format:mainfrom
wayneli-vt:update-operation-jni-impl

Conversation

@wayneli-vt
Copy link
Copy Markdown
Contributor

This PR enhances the Java bindings for Operation::Update as a follow-up to #4589.

While #4589 introduced new fields to the Rust Operation::Update struct, the Java bindings were still missing support not only for those new fields but also for the existing fields_modified field, which is crucial for handling column modifications.

Specifically, it adds support for the following fields:

  Update {
      // ...
      /// The fields that have been modified
      fields_modified: Vec<u32>,
      // 👇 New fields from #4589
      /// The fields that used to judge whether to preserve the new frag's id into
      /// the frag bitmap of the specified indices.
      fields_for_preserving_frag_bitmap: Vec<u32>,
      /// The mode of update
      update_mode: Option<UpdateMode>,
  }

@github-actions github-actions Bot added enhancement New feature or request java labels Sep 22, 2025
@github-actions
Copy link
Copy Markdown
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@wayneli-vt wayneli-vt marked this pull request as draft September 22, 2025 07:48
@wayneli-vt wayneli-vt changed the title feat(java): Expose additional Operation::Update fields to bindings feat(java): expose additional Operation::Update fields to bindings Sep 22, 2025
@wayneli-vt wayneli-vt marked this pull request as ready for review September 22, 2025 08:50
@wayneli-vt
Copy link
Copy Markdown
Contributor Author

@jackye1995 @yanghua This pr is ready for review when you have a moment. Thanks!

Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, pending CI

@wayneli-vt
Copy link
Copy Markdown
Contributor Author

wayneli-vt commented Sep 25, 2025

@jackye1995 My sincere apologies for the extra commit. I just pushed a fix for a code formatting issue that the CI caught.

Would you mind taking another quick look? Thank you very much for the extra review!

@jackye1995
Copy link
Copy Markdown
Contributor

Thanks for the work!!

@jackye1995 jackye1995 merged commit 39daa4c into lance-format:main Sep 25, 2025
7 checks passed
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
…ance-format#4788)

This PR enhances the Java bindings for Operation::Update as a follow-up
to lance-format#4589.

While lance-format#4589 introduced new fields to the Rust Operation::Update struct,
the Java bindings were still missing support not only for those new
fields but also for the existing `fields_modified field`, which is
crucial for handling column modifications.

Specifically, it adds support for the following fields:

```rust
  Update {
      // ...
      /// The fields that have been modified
      fields_modified: Vec<u32>,
      // 👇 New fields from lance-format#4589
      /// The fields that used to judge whether to preserve the new frag's id into
      /// the frag bitmap of the specified indices.
      fields_for_preserving_frag_bitmap: Vec<u32>,
      /// The mode of update
      update_mode: Option<UpdateMode>,
  }
```

---------

Co-authored-by: Weiren <litaiwei.lwt@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants