fix: correct null_count aggregation in boolean statistics collection#4839
Merged
wjones127 merged 1 commit intolance-format:mainfrom Dec 19, 2025
Merged
fix: correct null_count aggregation in boolean statistics collection#4839wjones127 merged 1 commit intolance-format:mainfrom
wjones127 merged 1 commit intolance-format:mainfrom
Conversation
Xuanwo
reviewed
Oct 14, 2025
Collaborator
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this and sorry for missing this PR.
Can you fix clippy and format? This PR is almost ready to go.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
done @Xuanwo |
Contributor
Code ReviewSummary: This PR fixes a bug where Assessment: ✅ ApproveThe bug fix is straightforward and correct:
The test case properly validates the fix by checking that null counts are correctly aggregated across multiple arrays. No issues identified. |
wjones127
approved these changes
Dec 19, 2025
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Dec 30, 2025
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_boolean_statistics function was incorrectly breaking early when both true and false values were found in the first array, causing subsequent arrays' null counts to be skipped. This resulted in incorrect null_count values when processing multiple batches.