Skip to content

fix: typo in ut test_fragment_update#4878

Merged
Xuanwo merged 1 commit intolance-format:mainfrom
wojiaodoubao:fix-ut-test_fragment_update
Oct 2, 2025
Merged

fix: typo in ut test_fragment_update#4878
Xuanwo merged 1 commit intolance-format:mainfrom
wojiaodoubao:fix-ut-test_fragment_update

Conversation

@wojiaodoubao
Copy link
Copy Markdown
Contributor

@wojiaodoubao wojiaodoubao commented Oct 2, 2025

A typo introduced by #4715. Conflict with #4860.

@github-actions github-actions Bot added the bug Something isn't working label Oct 2, 2025
@wojiaodoubao wojiaodoubao changed the title fix: ut test_fragment_update fix: typo in ut test_fragment_update Oct 2, 2025
@wojiaodoubao
Copy link
Copy Markdown
Contributor Author

Hi @jackye1995 @westonpace , could you help review this, it breaks the CI.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.85%. Comparing base (492e773) to head (09f8a12).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4878      +/-   ##
==========================================
- Coverage   80.87%   80.85%   -0.03%     
==========================================
  Files         332      333       +1     
  Lines      131687   131944     +257     
  Branches   131687   131944     +257     
==========================================
+ Hits       106507   106683     +176     
- Misses      21430    21510      +80     
- Partials     3750     3751       +1     
Flag Coverage Δ
unittests 80.85% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Xuanwo Xuanwo merged commit e3f8fbf into lance-format:main Oct 2, 2025
35 checks passed
wjones127 pushed a commit to wjones127/lance that referenced this pull request Oct 3, 2025
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants