Skip to content

chore: keep the large vectors#4914

Merged
BubbleCal merged 1 commit intolance-format:mainfrom
BubbleCal:handle-large-vectors
Oct 9, 2025
Merged

chore: keep the large vectors#4914
BubbleCal merged 1 commit intolance-format:mainfrom
BubbleCal:handle-large-vectors

Conversation

@BubbleCal
Copy link
Copy Markdown
Contributor

@BubbleCal BubbleCal commented Oct 9, 2025

related #4842
In #4890, we filter out the large vectors, this PR reverts that and try best to retrieve the large vectors:

  • if 2 vectors are both large but close to each other, the distance can be finite, so we can retrieve them
  • if 2 vectors are both large and the distance is infinite, we just return them in random order

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.61%. Comparing base (437e7f5) to head (e114883).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4914      +/-   ##
==========================================
- Coverage   81.61%   81.61%   -0.01%     
==========================================
  Files         333      333              
  Lines      131411   131406       -5     
  Branches   131411   131406       -5     
==========================================
- Hits       107257   107245      -12     
- Misses      20556    20563       +7     
  Partials     3598     3598              
Flag Coverage Δ
unittests 81.61% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BubbleCal BubbleCal merged commit b23fe01 into lance-format:main Oct 9, 2025
31 checks passed
@Baibaiwuguo
Copy link
Copy Markdown

@BubbleCal
hello. To avoid the situation where the denominator of the cosine is 0, could we consider adding a small positive number through dynamic setting?

jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
related lance-format#4842 
In lance-format#4890, we filter out the large
vectors, this PR reverts that and try best to retrieve the large
vectors:
- if 2 vectors are both large but close to each other, the distance can
be finite, so we can retrieve them
- if 2 vectors are both large and the distance is infinite, we just
return them in random order

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants