chore: keep the large vectors#4914
Merged
BubbleCal merged 1 commit intolance-format:mainfrom Oct 9, 2025
Merged
Conversation
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4914 +/- ##
==========================================
- Coverage 81.61% 81.61% -0.01%
==========================================
Files 333 333
Lines 131411 131406 -5
Branches 131411 131406 -5
==========================================
- Hits 107257 107245 -12
- Misses 20556 20563 +7
Partials 3598 3598
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wjones127
approved these changes
Oct 9, 2025
|
@BubbleCal |
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
related lance-format#4842 In lance-format#4890, we filter out the large vectors, this PR reverts that and try best to retrieve the large vectors: - if 2 vectors are both large but close to each other, the distance can be finite, so we can retrieve them - if 2 vectors are both large and the distance is infinite, we just return them in random order Signed-off-by: BubbleCal <bubble-cal@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #4842
In #4890, we filter out the large vectors, this PR reverts that and try best to retrieve the large vectors: