Skip to content

feat(java): support shallow_clone#4962

Merged
jackye1995 merged 6 commits intolance-format:mainfrom
majin1102:java-shallow_clone
Oct 17, 2025
Merged

feat(java): support shallow_clone#4962
jackye1995 merged 6 commits intolance-format:mainfrom
majin1102:java-shallow_clone

Conversation

@majin1102
Copy link
Copy Markdown
Contributor

Close #4854

@github-actions github-actions Bot added enhancement New feature or request java labels Oct 15, 2025
@majin1102
Copy link
Copy Markdown
Contributor Author

Ready for review @jackye1995

* @return a new Dataset instance at the target path
*/
public Dataset shallowClone(
String targetPath, long version, Optional<Map<String, String>> storageOptions) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a ShallowCloneOptions that contains version, tag and storage options? So it's easier to extend other options in the future. I think likely we also need a branch option later

Copy link
Copy Markdown
Contributor Author

@majin1102 majin1102 Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking of adding a Reference for extension. It could also be used in other cases like checkout.
Please take a look.

Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@jackye1995 jackye1995 merged commit 4d6b58c into lance-format:main Oct 17, 2025
7 checks passed
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
Close lance-format#4854

---------

Co-authored-by: majin.nathan <majin.nathan@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support shallow_clone in Java

2 participants