feat: dictionary index always32 bits#5011
Merged
Xuanwo merged 4 commits intolance-format:mainfrom Jan 28, 2026
Merged
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
yingjianwu98
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
yingjianwu98
force-pushed
the
haveDictionaryIndexAlways32Bits
branch
from
5909536 to
8b4eb37
Compare
…ways32Bits # Conflicts: # rust/lance-encoding/src/encodings/logical/primitive.rs
Xuanwo
approved these changes
Jan 22, 2026
vivek-bharathan
pushed a commit
to vivek-bharathan/lance
that referenced
this pull request
Feb 2, 2026
resolve lance-format#5005 The change makes variablewidth to also always use 32 bits, and the change should be backward compatible. --------- Co-authored-by: stevie9868 <yingjianwu2@email.com> Co-authored-by: Xuanwo <github@xuanwo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #5005
The change makes variablewidth to also always use 32 bits, and the change should be backward compatible.