fix: general block decompression mismatch for Lance 2.2 dictionaries#5025
Merged
fix: general block decompression mismatch for Lance 2.2 dictionaries#5025
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
westonpace
approved these changes
Oct 21, 2025
Member
westonpace
left a comment
There was a problem hiding this comment.
Do we still need impl BlockDecompressor for CompressedBufferEncoder?
Collaborator
Author
I think they don't need anymore, let me create a new PR to remove them. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5025 +/- ##
=======================================
Coverage 81.73% 81.74%
=======================================
Files 340 340
Lines 137432 137499 +67
Branches 137432 137499 +67
=======================================
+ Hits 112332 112395 +63
+ Misses 21377 21368 -9
- Partials 3723 3736 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #4900 enabled writing dictionary pages through
Compression::General, but the read pathDefaultDecompressionStrategy::create_block_decompressorstill routed those pages directly intoBinaryBlockDecompressor. When the compressed payload actually held fixed-width dictionary values (e.g., MiniBlockSchedulerDictionary with fixed Int8 lists), the first byte was reinterpreted asbits_per_offset, panicking insideBinaryBlockDecompressor.We didn't detect this during PR because we didn't add the test for
2.2version.This PR fixed this issue and added a new test to cover.
This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.