feat: implement create index and data replacement conflict rules#5077
Merged
westonpace merged 1 commit intolance-format:mainfrom Oct 28, 2025
Merged
Conversation
westonpace
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5077 +/- ##
==========================================
- Coverage 81.75% 81.69% -0.06%
==========================================
Files 340 340
Lines 138817 138845 +28
Branches 138817 138845 +28
==========================================
- Hits 113484 113431 -53
- Misses 21595 21676 +81
Partials 3738 3738
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…'t modify same field Also implement the other half of the resolver
westonpace
force-pushed
the
feat/create-index-data-replace-compat
branch
from
b62cddc to
81bff17
Compare
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…ce-format#5077) If we are creating an index on field X and a data replacement happens on field Y then this should not trigger a conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we are creating an index on field X and a data replacement happens on field Y then this should not trigger a conflict