fix: fts search should respect target fragment for scan#5081
Closed
yingjianwu98 wants to merge 1 commit intolance-format:mainfrom
Closed
fix: fts search should respect target fragment for scan#5081yingjianwu98 wants to merge 1 commit intolance-format:mainfrom
yingjianwu98 wants to merge 1 commit intolance-format:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
fixes #5063 |
Contributor
Author
|
Sorry for the direct ping, but I believe this bug could potentially have Lance to return results from unintended fragments. This might have broader implications so I want to bring this to your attention, thanks. |
jackye1995
reviewed
Dec 19, 2025
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
could we combine this with #5080 and have some sort of shared function like filter_to_scanner_fragments()?
|
|
||
| // Filter by scanner's fragment list to respect fragment restrictions | ||
| if let Some(scanner_frags) = &self.fragments { | ||
| let scanner_ids: std::collections::HashSet<_> = |
Contributor
There was a problem hiding this comment.
we can use self.get_fragments_as_bitmap(); in order to perform the same operation instead of using a hashset.
Contributor
Author
|
closing this in favor of #5924 |
wjones127
pushed a commit
that referenced
this pull request
Feb 17, 2026
…quested fragments (#5924) Fixes bug where vector and FTS searches ignore `with_fragments() `filter when querying unindexed fragments, which will return results from indexed fragments that were not requested. Note, this does not fix the issues where `with_fragments` contains both indexed_fragement and non_indexed_fragment for FTS and vector search, and I have a separate follow up PR to fix the behavior. This PR combines my previous effort for fixing the issue: #5081 #5080 --------- Co-authored-by: stevie9868 <yingjianwu2@email.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FTS search currently does not respect the target fragment list specified via Scanner.with_fragments().
Given a dataset with:
Scenario 1: Query targets only unindexed fragments [4, 5]
Scenario 2: Query targets mixed fragments [3, 4]