feat: add public accessors for count plan construction#5103
Merged
wkalt merged 3 commits intolance-format:mainfrom Nov 13, 2025
wkalt:task/make-create-count-plan-public
Merged
feat: add public accessors for count plan construction#5103wkalt merged 3 commits intolance-format:mainfrom wkalt:task/make-create-count-plan-public
wkalt merged 3 commits intolance-format:mainfrom
wkalt:task/make-create-count-plan-public
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5103 +/- ##
==========================================
- Coverage 81.69% 81.69% -0.01%
==========================================
Files 340 340
Lines 138845 138881 +36
Branches 138845 138881 +36
==========================================
+ Hits 113433 113456 +23
- Misses 21672 21684 +12
- Partials 3740 3741 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wjones127
reviewed
Nov 10, 2025
| &self.index_result | ||
| } | ||
|
|
||
| /// Get a reference to the applicable fragments bitmap |
Contributor
There was a problem hiding this comment.
Same here. I don't think the reader will immediately understand what "applicable fragments bitmap".
IIUC, it's the set of fragment ids that may contain matching rows.
This patch changes the count plan accessor to public, changes the get_deletion_vector method on fragments to public, and adds a couple public accessors on EvaluatedIndex. The purpose of this patch is to enable systems to construct and optimize the count plan using datafusion optimizer rules.
Co-authored-by: Will Jones <willjones127@gmail.com>
Contributor
Author
|
@wjones127 thanks, updated |
wjones127
approved these changes
Nov 13, 2025
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…5103) This patch changes the count plan accessor to public, changes the get_deletion_vector method on fragments to public, and adds a couple public accessors on EvaluatedIndex. The purpose of this patch is to enable systems to construct and optimize the count plan using datafusion optimizer rules. --------- Co-authored-by: Will Jones <willjones127@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes the count plan accessor to public, changes the get_deletion_vector method on fragments to public, and adds a couple public accessors on EvaluatedIndex.
The purpose of this patch is to enable systems to construct and optimize the count plan using datafusion optimizer rules.