fix: don't write beta version in WriterVersion#5113
Closed
wjones127 wants to merge 6 commits intolance-format:mainfrom
Closed
fix: don't write beta version in WriterVersion#5113wjones127 wants to merge 6 commits intolance-format:mainfrom
wjones127 wants to merge 6 commits intolance-format:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5113 +/- ##
==========================================
- Coverage 81.71% 81.68% -0.03%
==========================================
Files 340 340
Lines 138910 138912 +2
Branches 138910 138912 +2
==========================================
- Hits 113506 113474 -32
- Misses 21667 21702 +35
+ Partials 3737 3736 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
lol I also published the fix to continue to record the beta version here - #5116, I think that includes the change here |
westonpace
reviewed
Oct 31, 2025
Member
westonpace
left a comment
There was a problem hiding this comment.
How does this relate to #5116 ?
Contributor
Author
|
Closing in favor of #5116 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a forwards compatibility fix. Earlier versions of Lance expected the version string to exclusively be
X.Y.Z, but newer versions were writing withX.Y.Z-beta.Nsometimes. This caused writers on earlier versions to panic when writing, making the tables unwriteable.This is a companion to #5111, which made it so we don't panic if we encounter a version we can't parse.
Testing
I validated locally by:
Got:
The tests pass with the fix.