Skip to content

fix: don't write beta version in WriterVersion#5113

Closed
wjones127 wants to merge 6 commits intolance-format:mainfrom
wjones127:version-compatibility
Closed

fix: don't write beta version in WriterVersion#5113
wjones127 wants to merge 6 commits intolance-format:mainfrom
wjones127:version-compatibility

Conversation

@wjones127
Copy link
Copy Markdown
Contributor

@wjones127 wjones127 commented Oct 31, 2025

This is a forwards compatibility fix. Earlier versions of Lance expected the version string to exclusively be X.Y.Z, but newer versions were writing with X.Y.Z-beta.N sometimes. This caused writers on earlier versions to panic when writing, making the tables unwriteable.

This is a companion to #5111, which made it so we don't panic if we encounter a version we can't parse.

Testing

I validated locally by:

  • Commenting out the Rust change to omit the prerelease version
  • Changing the current Rust library version to be a prerelease
  • Running datagen with current version
  • Running forward compat tests with pylance==0.36.0

Got:

thread '<unnamed>' panicked at /Users/runner/work/lance/lance/rust/lance-table/src/format/manifest.rs:513:32:
Invalid writer version: 0.38.3-beta.1

The tests pass with the fix.

@github-actions github-actions Bot added bug Something isn't working python labels Oct 31, 2025
@wjones127 wjones127 marked this pull request as ready for review October 31, 2025 03:57
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.68%. Comparing base (056062a) to head (9814d94).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5113      +/-   ##
==========================================
- Coverage   81.71%   81.68%   -0.03%     
==========================================
  Files         340      340              
  Lines      138910   138912       +2     
  Branches   138910   138912       +2     
==========================================
- Hits       113506   113474      -32     
- Misses      21667    21702      +35     
+ Partials     3737     3736       -1     
Flag Coverage Δ
unittests 81.68% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jackye1995
Copy link
Copy Markdown
Contributor

lol I also published the fix to continue to record the beta version here - #5116, I think that includes the change here

Copy link
Copy Markdown
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this relate to #5116 ?

@wjones127
Copy link
Copy Markdown
Contributor Author

Closing in favor of #5116

@wjones127 wjones127 closed this Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants