refactor: remove not used storage class and blob dataset#5131
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Thanks for cleaning out this technical debt. I think we could maybe even get rid of more stuff. I'm not sure we have to worry about removing field metadata keys or migrating old use to the file version of blob data.
Looks like CI is not quite passing but once it is green I think this is good to go.
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
force-pushed
the
remove-not-used-storage-class
branch
from
5caccda to
9817357
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5131 +/- ##
==========================================
+ Coverage 81.73% 81.85% +0.12%
==========================================
Files 341 341
Lines 140755 140506 -249
Branches 140755 140506 -249
==========================================
- Hits 115044 115017 -27
+ Misses 21894 21683 -211
+ Partials 3817 3806 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…t#5131) This PR removes unused storage class and blob dataset to make our logic cleaner and easier to follow. That’s especially important as we work on support for blob v2 now. This PR includes breaking changes at the API level, but since we never used a blob dataset before, it won’t break users’ existing datasets. --- **This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.** --------- Signed-off-by: Xuanwo <github@xuanwo.io>
3 participants
This PR removes unused storage class and blob dataset to make our logic cleaner and easier to follow. That’s especially important as we work on support for blob v2 now.
This PR includes breaking changes at the API level, but since we never used a blob dataset before, it won’t break users’ existing datasets.
This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.