test: fix flaky SPFresh test#5138
Merged
BubbleCal merged 3 commits intolance-format:mainfrom Nov 5, 2025
Merged
Conversation
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5138 +/- ##
==========================================
+ Coverage 81.74% 81.86% +0.11%
==========================================
Files 341 341
Lines 140915 140541 -374
Branches 140915 140541 -374
==========================================
- Hits 115198 115056 -142
+ Misses 21900 21679 -221
+ Partials 3817 3806 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks for working on this. I’ll just try to fix it. |
Xuanwo
approved these changes
Nov 5, 2025
westonpace
approved these changes
Nov 5, 2025
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Thanks for working on these tests!
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
This uses fixed data for testing spfresh to avoid flaky tests --------- Signed-off-by: BubbleCal <bubble-cal@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses fixed data for testing spfresh to avoid flaky tests