fix: use typed LanceNamespace for python storage options provider#5151
Merged
jackye1995 merged 1 commit intolance-format:mainfrom Nov 5, 2025
Merged
fix: use typed LanceNamespace for python storage options provider#5151jackye1995 merged 1 commit intolance-format:mainfrom
jackye1995 merged 1 commit intolance-format:mainfrom
Conversation
jackye1995
commented
Nov 5, 2025
| else: | ||
| merged_storage_options = namespace_storage_options | ||
| storage_options = merged_storage_options | ||
| namespace_storage_options = response.storage_options |
Contributor
Author
There was a problem hiding this comment.
make it consistent with how lance.dataset handles the storage options
jackye1995
commented
Nov 5, 2025
| storage_options = merged_storage_options | ||
| namespace_storage_options = response.storage_options | ||
| if namespace_storage_options: | ||
| # TODO: support dynamic storage options provider |
Contributor
Author
There was a problem hiding this comment.
this I will put a separated PR, need to properly handle CreateEmptyTable case
bryanck
approved these changes
Nov 5, 2025
LuQQiu
approved these changes
Nov 5, 2025
jackye1995
added a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…nce-format#5151) Fix the error that we did not use proper request response style calls to perform describe_table in python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the error that we did not use proper request response style calls to perform describe_table in python.