feat: support namespace vended credentials for write#5161
feat: support namespace vended credentials for write#5161jackye1995 merged 4 commits intolance-format:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5161 +/- ##
==========================================
+ Coverage 82.25% 82.27% +0.01%
==========================================
Files 344 344
Lines 144636 144901 +265
Branches 144636 144901 +265
==========================================
+ Hits 118967 119211 +244
- Misses 21742 21755 +13
- Partials 3927 3935 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jackye1995
force-pushed
the
vending-write
branch
3 times, most recently
from
b616759 to
e88f45f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
jackye1995
force-pushed
the
vending-write
branch
from
e88f45f to
3c49522
Compare
jackye1995
force-pushed
the
vending-write
branch
from
3c49522 to
7872490
Compare
This PR extends upon lance-format#4905 for 2 features: 1. when writing, the dataset might not exist yet, we add convenient method `write_into_namespace` which calls `namespace.create_empty_table` to create the empty table, get its URI and storage options to use (if any), and use that to create the table. 2. pass in storage options provider to: 1. write_fragments for distributed write 2. Lance file writer for callers that write individual lance files in the same table directory but not in the lance table note: this PR only offers rust and python implementation, java will be added later
2 participants
This PR extends upon #4905 for 2 features:
write_into_namespacewhich callsnamespace.create_empty_tableto create the empty table, get its URI and storage options to use (if any), and use that to create the table.note: this PR only offers rust and python implementation, java will be added later