Skip to content

fix: split partition may be assigned to itself#5190

Merged
BubbleCal merged 3 commits intolance-format:mainfrom
BubbleCal:assign-to-joined-part
Nov 10, 2025
Merged

fix: split partition may be assigned to itself#5190
BubbleCal merged 3 commits intolance-format:mainfrom
BubbleCal:assign-to-joined-part

Conversation

@BubbleCal
Copy link
Copy Markdown
Contributor

@BubbleCal BubbleCal commented Nov 7, 2025

This could happen if 2 partitions have the same centroid

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions Bot added the bug Something isn't working label Nov 7, 2025
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.00%. Comparing base (d8f9dcb) to head (d3f0851).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/index/vector/builder.rs 90.56% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5190      +/-   ##
==========================================
+ Coverage   81.83%   82.00%   +0.17%     
==========================================
  Files         341      341              
  Lines      140682   141133     +451     
  Branches   140682   141133     +451     
==========================================
+ Hits       115122   115735     +613     
+ Misses      21752    21587     -165     
- Partials     3808     3811       +3     
Flag Coverage Δ
unittests 82.00% <90.56%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BubbleCal BubbleCal merged commit c281b24 into lance-format:main Nov 10, 2025
34 of 36 checks passed
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
This could happen if 2 partitions have the same centroid

---------

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants