Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
wjones127
approved these changes
Nov 7, 2025
Contributor
wjones127
left a comment
wjones127
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
This PR will fix lance-format#5171. BloomFilter only provides `AtMost` for `IS NULL`. Our planner implements `IS NOT NULL` as `NOT (IS NULL)`, which causes the BloomFilter result to be treated as `AtLeast`. But this is incorrect for BloomFilter. Additionally, FilteredReadExec treats `AtLeast` as exact, which can drop many ranges that might contain `NOT NULL`. We fixed this by adding a recheck before applying `NOT` to BloomFilter. --- **This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.** --------- Signed-off-by: Xuanwo <github@xuanwo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix #5171.
BloomFilter only provides
AtMostforIS NULL. Our planner implementsIS NOT NULLasNOT (IS NULL), which causes the BloomFilter result to be treated asAtLeast. But this is incorrect for BloomFilter. Additionally, FilteredReadExec treatsAtLeastas exact, which can drop many ranges that might containNOT NULL.We fixed this by adding a recheck before applying
NOTto BloomFilter.This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.