Skip to content

fix: compile error in test_inline_transaction#5206

Merged
wjones127 merged 1 commit intolance-format:mainfrom
wojiaodoubao:fix-typo-test-inline-trnasaction
Nov 11, 2025
Merged

fix: compile error in test_inline_transaction#5206
wjones127 merged 1 commit intolance-format:mainfrom
wojiaodoubao:fix-typo-test-inline-trnasaction

Conversation

@wojiaodoubao
Copy link
Copy Markdown
Contributor

@wojiaodoubao wojiaodoubao commented Nov 11, 2025 •
edited
Loading

Fix compile error

@github-actions github-actions Bot added the bug Something isn't working label Nov 11, 2025
@wojiaodoubao wojiaodoubao force-pushed the fix-typo-test-inline-trnasaction branch from 05afd0f to 230db0d Compare November 11, 2025 03:57
@wojiaodoubao wojiaodoubao mentioned this pull request Nov 11, 2025
Merged
@yanghua
Copy link
Copy Markdown
Collaborator

yanghua commented Nov 11, 2025

It seems it's not a typo, it's a compile error?

@wojiaodoubao wojiaodoubao changed the title fix: fix typo in test_inline_transaction fix: compile error in test_inline_transaction Nov 11, 2025
@wojiaodoubao
Copy link
Copy Markdown
Contributor Author

wojiaodoubao commented Nov 11, 2025

It seems it's not a typo, it's a compile error?

Yes, there is a conflict when merging the inline transaction pr, causing a compile error. Could you help review when you have time, thanks very much~ @yanghua

yanghua
yanghua approved these changes Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yanghua
Copy link
Copy Markdown
Collaborator

yanghua commented Nov 11, 2025

Giving the failed CI a chance, when it passes, will merge soon.

@yanghua
Copy link
Copy Markdown
Collaborator

yanghua commented Nov 11, 2025

@Xuanwo I found many CI runs failed due to these cases:

failures:
    dataset::blob::tests::test_take_blob_id_not_exist
    dataset::blob::tests::test_take_blob_not_blob_col
    dataset::blob::tests::test_take_blobs

Would you please take a look?

@wjones127 wjones127 merged commit 551ce82 into lance-format:main Nov 11, 2025
51 of 58 checks passed
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
@wojiaodoubao @jackye1995
fix: compile error in test_inline_transaction (lance-format#5206)
a9450cb 
Fix compile error

Co-authored-by: lijinglun <lijinglun@bytedance.com>
@andrea-reale andrea-reale mentioned this pull request Mar 30, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanghua yanghua yanghua approved these changes

@wjones127 wjones127 wjones127 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wojiaodoubao @yanghua @wjones127