refactor!: move all previous code into previous mod#5217
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
…into previous-refactor
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Thanks for tackling this cleanup. I like the change as it is more obvious when people are using something old. It would be nice if we could drop the old reader/writer someday but I don't know if we can yet.
| use lance_core::datatypes::Schema; | ||
| use lance_encoding::decoder::{DecoderPlugins, FilterExpression}; | ||
| use lance_file::v2::reader::{FileReader, FileReaderOptions, ReaderProjection}; | ||
| use lance_file::reader::{FileReader, FileReaderOptions, ReaderProjection}; |
There was a problem hiding this comment.
This is a breaking rust-level change. There are potentially a few (maybe not very many) Rust users who use FileReader directly. I think we can still proceed with the change (we haven't ever claimed the Rust API is stable) but we should maybe mark the PR as breaking.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5217 +/- ##
==========================================
- Coverage 82.02% 82.01% -0.02%
==========================================
Files 342 342
Lines 141495 141516 +21
Branches 141495 141516 +21
==========================================
- Hits 116059 116058 -1
- Misses 21595 21618 +23
+ Partials 3841 3840 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
) This PR will move all previous code into `previous` mod to make our code more clean for both human and AI. This PR will also add clear alias of previous code like `PreviousReader`. --- **This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.** --------- Signed-off-by: Xuanwo <github@xuanwo.io>
3 participants
This PR will move all previous code into
previousmod to make our code more clean for both human and AI.This PR will also add clear alias of previous code like
PreviousReader.This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.