refactor: move blob version as a table level config#5220
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
…nto blob-v2-settings
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5220 +/- ##
==========================================
- Coverage 82.22% 82.19% -0.03%
==========================================
Files 344 344
Lines 144687 144732 +45
Branches 144687 144732 +45
==========================================
+ Hits 118962 118965 +3
- Misses 21807 21843 +36
- Partials 3918 3924 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
westonpace
left a comment
There was a problem hiding this comment.
This is good but I have one question about where this is going.
Close lance-format#5163 This PR will move blob version as a table level config instead. --- **This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.** --------- Signed-off-by: Xuanwo <github@xuanwo.io>
Close #5163
This PR will move blob version as a table level config instead.
This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.