Skip to content

refactor: move blob version as a table level config#5220

Merged
Xuanwo merged 12 commits intomainfrom
blob-v2-settings
Nov 17, 2025
Merged

refactor: move blob version as a table level config#5220
Xuanwo merged 12 commits intomainfrom
blob-v2-settings

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Nov 12, 2025

Close #5163

This PR will move blob version as a table level config instead.


This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.

Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rust/lance/src/dataset/blob.rs
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 50.90909% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.19%. Comparing base (8b3da7f) to head (9ee72ea).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/dataset/blob.rs 32.69% 34 Missing and 1 partial ⚠️
rust/lance-core/src/datatypes/field.rs 56.25% 7 Missing ⚠️
rust/lance/src/dataset/transaction.rs 33.33% 4 Missing and 2 partials ⚠️
rust/lance/src/dataset/write/insert.rs 70.58% 4 Missing and 1 partial ⚠️
rust/lance-core/src/datatypes/schema.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5220      +/-   ##
==========================================
- Coverage   82.22%   82.19%   -0.03%     
==========================================
  Files         344      344              
  Lines      144687   144732      +45     
  Branches   144687   144732      +45     
==========================================
+ Hits       118962   118965       +3     
- Misses      21807    21843      +36     
- Partials     3918     3924       +6     
Flag Coverage Δ
unittests 82.19% <50.90%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Xuanwo Xuanwo requested a review from westonpace November 14, 2025 10:07
Copy link
Copy Markdown
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but I have one question about where this is going.

Comment thread rust/lance-core/src/datatypes/field.rs
@Xuanwo Xuanwo merged commit 27d8ac5 into main Nov 17, 2025
29 checks passed
@Xuanwo Xuanwo deleted the blob-v2-settings branch November 17, 2025 15:48
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
Close lance-format#5163

This PR will move blob version as a table level config instead.

---

**This PR was primarily authored with Codex using GPT-5-Codex and then
hand-reviewed by me. I AM responsible for every change made in this PR.
I aimed to keep it aligned with our goals, though I may have missed
minor issues. Please flag anything that feels off, I'll fix it
quickly.**

---------

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Naming discussion around blob v2

3 participants