feat: add target_bases extension to python write_fragments API#5234
Merged
jackye1995 merged 4 commits intolance-format:mainfrom Nov 18, 2025
Merged
feat: add target_bases extension to python write_fragments API#5234jackye1995 merged 4 commits intolance-format:mainfrom
jackye1995 merged 4 commits intolance-format:mainfrom
Conversation
jaystarshot
force-pushed
the
jay-fix-fragments
branch
from
8dbf2ff to
eea5ed8
Compare
jaystarshot
force-pushed
the
jay-fix-fragments
branch
from
eea5ed8 to
740a0ab
Compare
jackye1995
reviewed
Nov 14, 2025
jaystarshot
force-pushed
the
jay-fix-fragments
branch
2 times, most recently
from
b64df0e to
be2264c
Compare
jaystarshot
force-pushed
the
jay-fix-fragments
branch
from
be2264c to
212739e
Compare
jackye1995
reviewed
Nov 18, 2025
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
mostly looks good to me, just a nit
| if let Some(bases_list) = initial_bases_py { | ||
| cls.call1((schema_py, fragments_py, bases_list)) | ||
| } else { | ||
| cls.call1((schema_py, fragments_py)) |
Contributor
There was a problem hiding this comment.
I think once you added initial_bases to the Overwrite model, since it's a data class, you won't really be able to invoke this constructor?
Contributor
Author
There was a problem hiding this comment.
initial_bases in the overwrite has a default value of None:
Contributor
There was a problem hiding this comment.
but in that case bases_list will also be None right? so cls.call1((schema_py, fragments_py, bases_list)) should still work?
Contributor
Author
There was a problem hiding this comment.
Ahh yes thanks, i explicitly set to only none now
Contributor
Author
There was a problem hiding this comment.
i think previously it was a rust none and just need to convert to python none
jaystarshot
force-pushed
the
jay-fix-fragments
branch
from
65698c1 to
ad3035e
Compare
jackye1995
approved these changes
Nov 18, 2025
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…-format#5234) The lance.write_dataset() function already supports writing to multiple storage buckets via the target_bases parameter in lance-format#4765 However, write_fragments() did not expose this capability, even though the underlying Rust implementation _write_fragments, _write_fragments_transaction already supported it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lance.write_dataset() function already supports writing to multiple storage buckets via the target_bases parameter in #4765
However, write_fragments() did not expose this capability, even though the underlying Rust implementation
_write_fragments, _write_fragments_transaction already supported it