Skip to content

fix: clearer error in dataset take#5243

Merged
wkalt merged 1 commit intomainfrom
task/clarify-error-message
Nov 17, 2025
Merged

fix: clearer error in dataset take#5243
wkalt merged 1 commit intomainfrom
task/clarify-error-message

Conversation

@wkalt
Copy link
Copy Markdown
Contributor

@wkalt wkalt commented Nov 14, 2025

This changes an error message to provide detail in the same way as elsewhere in the file.

This changes an error message to provide detail in the same way as
elsewhere in the file.
@github-actions github-actions Bot added the bug Something isn't working label Nov 14, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.25%. Comparing base (7c19c22) to head (df29571).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/dataset/take.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5243      +/-   ##
==========================================
+ Coverage   82.23%   82.25%   +0.01%     
==========================================
  Files         344      344              
  Lines      144765   144766       +1     
  Branches   144765   144766       +1     
==========================================
+ Hits       119050   119079      +29     
+ Misses      21797    21766      -31     
- Partials     3918     3921       +3     
Flag Coverage Δ
unittests 82.25% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wkalt wkalt merged commit 1863e65 into main Nov 17, 2025
28 of 29 checks passed
@wkalt wkalt deleted the task/clarify-error-message branch November 17, 2025 14:25
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
This changes an error message to provide detail in the same way as
elsewhere in the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants