refactor: write bitmap index statistics in file instead#5251
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Xuanwo <github@xuanwo.io>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
wjones127
left a comment
There was a problem hiding this comment.
Some suggestions to modernize io tracking
Co-authored-by: Will Jones <willjones127@gmail.com>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
There was a problem hiding this comment.
Approve pending CI green.
I think we're good here on backwards / forwards compatibility?
If new code is reading an old index then if let Some(stats) = plugin.load_statistics(index_store.clone(), index_details.as_ref()).await? fails and we fallback to the old approach?
If old code is reading a new index then the old approach should still work since we didn't get rid of any information.
We should probably add "get statistics" to the forwards / backwards compatibility test suites at some point but perhaps can be in a follow-up?
Yes, we should be good on this, either way works.
Makes sense to me. |
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
…#5251) Close lance-format#4620 This PR will write bitmap index statistics in file instead so we don't need to load the entire index file to calculate it. --- **This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.** --------- Signed-off-by: Xuanwo <github@xuanwo.io> Co-authored-by: Will Jones <willjones127@gmail.com>
Close #4620
This PR will write bitmap index statistics in file instead so we don't need to load the entire index file to calculate it.
This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.