chore: respect num_indices_to_merge param#5253
Merged
BubbleCal merged 2 commits intolance-format:mainfrom Nov 17, 2025
Merged
Conversation
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5253 +/- ##
==========================================
+ Coverage 82.25% 82.27% +0.02%
==========================================
Files 344 344
Lines 144636 144901 +265
Branches 144636 144901 +265
==========================================
+ Hits 118967 119219 +252
- Misses 21742 21751 +9
- Partials 3927 3931 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Xuanwo
reviewed
Nov 17, 2025
| ivf: &IvfModel, | ||
| reader: &dyn ShuffleReader, | ||
| existing_indices: &[Arc<dyn VectorIndex>], | ||
| num_indices_to_merge: Option<usize>, |
Collaborator
There was a problem hiding this comment.
This API change really surprised me. If we just input an Option and return Ok(None) if it's some, how about we do this check outside?
Xuanwo
approved these changes
Nov 17, 2025
Collaborator
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
if `num_indices_to_merge` is passed, don't trigger SPFresh split --------- Signed-off-by: BubbleCal <bubble-cal@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if
num_indices_to_mergeis passed, don't trigger SPFresh split