feat: support credentials vending for file reader and session#5256
Merged
jackye1995 merged 11 commits intolance-format:mainfrom Nov 19, 2025
Merged
feat: support credentials vending for file reader and session#5256jackye1995 merged 11 commits intolance-format:mainfrom
jackye1995 merged 11 commits intolance-format:mainfrom
Conversation
jackye1995
force-pushed
the
file-reader-vending
branch
from
6b31f0b to
bcbbd5b
Compare
jackye1995
force-pushed
the
file-reader-vending
branch
from
e0e542d to
3973485
Compare
jackye1995
commented
Nov 19, 2025
| } | ||
| } | ||
|
|
||
| log::debug!( |
Contributor
Author
There was a problem hiding this comment.
add some additional logging since customers could plugin custom logic here and might be hard to debug
Xuanwo
approved these changes
Nov 19, 2025
Collaborator
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
approved as a workaround, we'll finally remove them.
Contributor
Author
|
Failing CI fixed in newer PRs, merging |
jackye1995
added a commit
that referenced
this pull request
Nov 25, 2025
jackye1995
added a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…format#5256) Allow user to directly create a LanceFileReader or LanceFileSession with storage options provider to refresh vended credentials. We also add a few methods in LanceFileSession for generic object store usage, these are more as workarounds because there is no practical solutions today for an IO library with pluggable credentials provider. The long term plan is to use OpenDAL for related workloads.
jackye1995
added a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow user to directly create a LanceFileReader or LanceFileSession with storage options provider to refresh vended credentials.
We also add a few methods in LanceFileSession for generic object store usage, these are more as workarounds because there is no practical solutions today for an IO library with pluggable credentials provider. The long term plan is to use OpenDAL for related workloads.