fix: remove logging for project_batch#5267
Merged
westonpace merged 1 commit intolance-format:mainfrom Dec 5, 2025
Merged
Conversation
wjones127
approved these changes
Nov 18, 2025
westonpace
force-pushed
the
fix/remove-extraneous-plan-run
branch
from
2b548ab to
f228d49
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Dec 5, 2025
I've noticed that debug / info logging has been flooded lately with things like... ``` [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 ``` This is because we create and execute a dummy plan to apply projection. This "dummy plan execution" is overly heavyweight on its own and should be optimized (see lance-format#5069). However, this short-term patch will at least remove the extraneous logging
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Dec 5, 2025
I've noticed that debug / info logging has been flooded lately with things like... ``` [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 ``` This is because we create and execute a dummy plan to apply projection. This "dummy plan execution" is overly heavyweight on its own and should be optimized (see lance-format#5069). However, this short-term patch will at least remove the extraneous logging
jackye1995
pushed a commit
that referenced
this pull request
Dec 5, 2025
I've noticed that debug / info logging has been flooded lately with things like... ``` [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 ``` This is because we create and execute a dummy plan to apply projection. This "dummy plan execution" is overly heavyweight on its own and should be optimized (see #5069). However, this short-term patch will at least remove the extraneous logging
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
I've noticed that debug / info logging has been flooded lately with things like... ``` [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 [2025-11-18T14:12:05Z INFO lance::events] target="lance::execution" type="plan_run" plan_summary="Projection(OneShot)" output_rows=2 iops=0 requests=0 bytes_read=0 indices_loaded=0 parts_loaded=0 index_comparisons=0 ``` This is because we create and execute a dummy plan to apply projection. This "dummy plan execution" is overly heavyweight on its own and should be optimized (see lance-format#5069). However, this short-term patch will at least remove the extraneous logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that debug / info logging has been flooded lately with things like...
This is because we create and execute a dummy plan to apply projection. This "dummy plan execution" is overly heavyweight on its own and should be optimized (see #5069). However, this short-term patch will at least remove the extraneous logging