refactor: add helper functions to delta.rs tests#5298
Merged
jackye1995 merged 3 commits intolance-format:mainfrom Nov 20, 2025
Merged
refactor: add helper functions to delta.rs tests#5298jackye1995 merged 3 commits intolance-format:mainfrom
jackye1995 merged 3 commits intolance-format:mainfrom
Conversation
jackye1995
approved these changes
Nov 20, 2025
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
I think there is always a debate of do we want to create more util methods for testing, but those might become limiting factors in writing tests. But having these at least limited in the specific test mod for delta.rs seems good to me
jackye1995
changed the title
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.