fix: stop documenting FTS index type, standardize on INVERTED#5315
Merged
westonpace merged 1 commit intolance-format:mainfrom Dec 4, 2025
Merged
fix: stop documenting FTS index type, standardize on INVERTED#5315westonpace merged 1 commit intolance-format:mainfrom
westonpace merged 1 commit intolance-format:mainfrom
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
westonpace
approved these changes
Nov 24, 2025
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
If we're sure it wasn't working before then this change seems fine to me (and the fact that no tests failed or needed changed is a sign this wasn't tested at all).
Can you fix up the PR title before you merge so it conforms to https://www.conventionalcommits.org/en/v1.0.0/?
mackrorysd
changed the title
mackrorysd
force-pushed
the
fix-issue-5314
branch
from
7738f7f to
a2665e1
Compare
Contributor
Author
|
@westonpace Thanks - fixed the commit message and CI passed on the rerun. |
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…format#5315) For this issue: lance-format#5314. No test included because this is removing behavior that currently doesn't work and is only partially documented (unless we decide we want to fully implement an FTS alias for INVERTED indices. INVERTED index tests should continue to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For this issue: #5314.
No test included because this is removing behavior that currently doesn't work and is only partially documented (unless we decide we want to fully implement an FTS alias for INVERTED indices. INVERTED index tests should continue to work.