fix: add graceful shutdown and start for rest namespace adapter#5325
Merged
jackye1995 merged 8 commits intolance-format:mainfrom Dec 2, 2025
Merged
fix: add graceful shutdown and start for rest namespace adapter#5325jackye1995 merged 8 commits intolance-format:mainfrom
jackye1995 merged 8 commits intolance-format:mainfrom
Conversation
jackye1995
force-pushed
the
ns-flaky
branch
2 times, most recently
from
1d9bab5 to
24e1454
Compare
Contributor
Author
|
Added some logging and found the issue: Basically the server of last test was still active, thus the new server fails to start and the client still calls into the old server. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
jackye1995
changed the title
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
westonpace
requested changes
Dec 1, 2025
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Some minor suggestions but seems fine otherwise
| if let Some(server_handle) = adapter.server_handle.take() { | ||
| server_handle.abort(); | ||
| server_handle.shutdown(); | ||
| std::thread::sleep(std::time::Duration::from_millis(100)); |
Member
There was a problem hiding this comment.
Can we add a comment about why this sleep is needed?
|
|
||
| // Use a random port to avoid conflicts | ||
| port = 4000 + new Random().nextInt(10000); | ||
| port = 10000 + new Random().nextInt(10000); |
Member
There was a problem hiding this comment.
I suspect you already know but the canonical solution to this problem that I'm used to seeing is to use port number 0 and have that pass all the way down to the socket opening. Then the OS will assign a random ephemeral port and you can either return that from the constructor or make it available via an accessor.
Not sure if that is easily doable or possible but figured I'd mention it.
Comment on lines
+125
to
+128
| /// Gracefully shut down the server. | ||
| /// | ||
| /// This signals the server to stop accepting new connections and wait for | ||
| /// existing connections to complete. |
Member
There was a problem hiding this comment.
This method doesn't actually block until the shutdown is complete though right? I feel like we should document that fact (or ideally find some way to block?)
westonpace
approved these changes
Dec 2, 2025
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Sweet. Thanks for doing the ephemeral port change!
jackye1995
added a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…e-format#5325) Closes lance-format#5293 The test was flaky because the server in the last test is not properly shut down, and the one in new test fails to start and then client talks to the server in the last test. Made the RestAdapter run non-blocking start instead of blocking serve, so that the python and java level can more gracefully handle start and shutdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5293
The test was flaky because the server in the last test is not properly shut down, and the one in new test fails to start and then client talks to the server in the last test.
Made the RestAdapter run non-blocking start instead of blocking serve, so that the python and java level can more gracefully handle start and shutdown.