fix: correctly handle OSS commit protocol to prevent data loss#5332
Merged
wjones127 merged 1 commit intolance-format:mainfrom Nov 24, 2025
Merged
fix: correctly handle OSS commit protocol to prevent data loss#5332wjones127 merged 1 commit intolance-format:mainfrom
wjones127 merged 1 commit intolance-format:mainfrom
Conversation
Xuanwo
approved these changes
Nov 24, 2025
wjones127
approved these changes
Nov 24, 2025
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…-format#5332) Previously, OSS protocol was falling back to UnsafeCommitHandler which can lead to data loss during concurrent writes. This change ensures OSS uses the ConditionalPutCommitHandler which leverages the x-oss-forbid-overwrite header to provide proper concurrency control similar to other cloud storage protocols. > ℹ️ **Note**: This is my first contribution to open source! > I'm excited to be part of the community 🙌 > Please feel free to point out anything I can improve — I'm happy to learn and make changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, OSS protocol was falling back to UnsafeCommitHandler which can lead to data loss during concurrent writes. This change ensures OSS uses the ConditionalPutCommitHandler which leverages the x-oss-forbid-overwrite header to provide proper concurrency control similar to other cloud storage protocols.