test: remove substrait-expr dependency#5335
Merged
westonpace merged 2 commits intolance-format:mainfrom Nov 25, 2025
Merged
Conversation
timsaucer
approved these changes
Nov 25, 2025
Contributor
timsaucer
left a comment
timsaucer
left a comment
There was a problem hiding this comment.
I was looking at doing the same thing, but it required getting way deeper into the substrait proto messages than I was comfortable doing. I agree this looks a bit messy, but removing the dependency seems like a very good thing for longer term maintainability.
westonpace
force-pushed
the
test/remove-substrait-expr-dep
branch
from
7ec3a12 to
c34c165
Compare
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
I'm going to go ahead and just archive substrait-expr. We were only using it in lance for one unit test. Admittedly the unit test is uglier now but I think it's fine to remove a dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm going to go ahead and just archive substrait-expr. We were only using it in lance for one unit test. Admittedly the unit test is uglier now but I think it's fine to remove a dependency.