refactor: allow datafiles to contain columns without field id#5348
Merged
refactor: allow datafiles to contain columns without field id#5348
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
westonpace
approved these changes
Nov 26, 2025
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Xuanwo <github@xuanwo.io>
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…format#5348) This PR removes the check that requires all columns in data files to have a field ID. The check was only for safety and doesn’t enforce any real restriction in our logic. I’m removing it so we can keep building Blob V2. --- **This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.** --------- Signed-off-by: Xuanwo <github@xuanwo.io> Co-authored-by: Weston Pace <weston.pace@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the check that requires all columns in data files to have a field ID. The check was only for safety and doesn’t enforce any real restriction in our logic. I’m removing it so we can keep building Blob V2.
This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.