Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
thanks for this! looks like some tests have been queued for the past 3 hours or so, is that expected? |
Yes there are some issues with Github runners right now, we are working on switching to use 3rd party runners |
|
were you already able to test with this public hf dataset @Xuanwo? |
|
@Xuanwo can you rebase main and the CI should work now |
…control' into Xuanwo/hf-fragment-control
|
Hi, @pavanramkumar, yes, it works!
However, we didn't support |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Fantastic! I just tested this now and it works. Thank you!
Specifying a revision also works nicely! It's not urgent, but I don't see |
Close lance-format#5346 This PR adds native support of huggingface in lance. --- **This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.** --------- Signed-off-by: Xuanwo <github@xuanwo.io>

Close #5346
This PR adds native support of huggingface in lance.
This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.