fix: parallelize bitmap partition loading in IsIn expressions#5355
Merged
Xuanwo merged 3 commits intolance-format:mainfrom Dec 1, 2025
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Prior to this commit an IsIn query on a bitmap index would load partitions in serial order. On high latency connections, queries with large IsIn lists can get very slow. This commit changes the partition loading to be parallelized over the number of CPUs, similar to btree.
wkalt
force-pushed
the
task/parallelize-bitmap-partition-loading
branch
from
58c8137 to
d88f117
Compare
Contributor
Author
|
Here is some performance data |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
BubbleCal
approved these changes
Nov 27, 2025
| let this = self.clone(); | ||
| async move { this.load_bitmap(&key, None).await } | ||
| })) | ||
| .buffered(get_num_compute_intensive_cpus()) |
Contributor
There was a problem hiding this comment.
it looks like we don't care the order, buffered_unordered may offer better performance
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…format#5355) Prior to this commit an IsIn query on a bitmap index would load partitions in serial order. On high latency connections, queries with large IsIn lists can get very slow. This commit changes the partition loading to be parallelized over the number of CPUs, similar to btree.
wkalt
added a commit
to wkalt/lance
that referenced
this pull request
Jan 26, 2026
…format#5355) Prior to this commit an IsIn query on a bitmap index would load partitions in serial order. On high latency connections, queries with large IsIn lists can get very slow. This commit changes the partition loading to be parallelized over the number of CPUs, similar to btree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit an IsIn query on a bitmap index would load partitions in serial order. On high latency connections, queries with large IsIn lists can get very slow. This commit changes the partition loading to be parallelized over the number of CPUs, similar to btree.