Skip to content

chore: add more information while error happened#5357

Merged
Xuanwo merged 3 commits intomainfrom
Xuanwo/log-merge-dataset-info
Nov 27, 2025
Merged

chore: add more information while error happened#5357
Xuanwo merged 3 commits intomainfrom
Xuanwo/log-merge-dataset-info

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Nov 27, 2025

This PR will add more information when an error occurs to make debugging easier.


This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.

Signed-off-by: Xuanwo <github@xuanwo.io>
@github-actions github-actions Bot added the chore label Nov 27, 2025
@Xuanwo Xuanwo merged commit 913a159 into main Nov 27, 2025
25 checks passed
@Xuanwo Xuanwo deleted the Xuanwo/log-merge-dataset-info branch November 27, 2025 06:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 4.65116% with 41 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/io/exec/take.rs 8.33% 21 Missing and 1 partial ⚠️
rust/lance/src/dataset/write/merge_insert.rs 0.00% 18 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
This PR will add more information when an error occurs to make debugging
easier.

---

**This PR was primarily authored with Codex using GPT-5-Codex and then
hand-reviewed by me. I AM responsible for every change made in this PR.
I aimed to keep it aligned with our goals, though I may have missed
minor issues. Please flag anything that feels off, I'll fix it
quickly.**

---------

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants