refactor: separate out python and java LanceNamespace interface#5364
Merged
jackye1995 merged 5 commits intolance-format:mainfrom Nov 28, 2025
Merged
refactor: separate out python and java LanceNamespace interface#5364jackye1995 merged 5 commits intolance-format:mainfrom
jackye1995 merged 5 commits intolance-format:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Xuanwo
approved these changes
Nov 28, 2025
jackye1995
added a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…e-format#5364) This is a partial revert of lance-format#5345. Because lancedb does not depend on pylance (except for in tests), we cannot put the LanceNamespace pluggable interface in pylance directly, so move back to use lance_namesapce python module. Also do the same for java for consistency. For rust, because it is a source build, we have concluded that it should remain in core lance repo for easy import. For more details, see latest https://lance.org/community/project-specific/namespace/#dependency-diagram
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial revert of #5345. Because lancedb does not depend on pylance (except for in tests), we cannot put the LanceNamespace pluggable interface in pylance directly, so move back to use lance_namesapce python module. Also do the same for java for consistency. For rust, because it is a source build, we have concluded that it should remain in core lance repo for easy import.
For more details, see latest https://lance.org/community/project-specific/namespace/#dependency-diagram