Skip to content

feat: dynamically choose distance type#5370

Merged
BubbleCal merged 3 commits intolance-format:mainfrom
BubbleCal:default-distance-type
Nov 28, 2025
Merged

feat: dynamically choose distance type#5370
BubbleCal merged 3 commits intolance-format:mainfrom
BubbleCal:default-distance-type

Conversation

@BubbleCal
Copy link
Copy Markdown
Contributor

resolve #3398

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions Bot added enhancement New feature or request python labels Nov 28, 2025
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread python/python/tests/test_vector.py
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 86.36364% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/dataset/scanner.rs 87.09% 1 Missing and 7 partials ⚠️
rust/lance/src/index/vector/utils.rs 91.66% 2 Missing ⚠️
rust/lance/src/io/exec/knn.rs 0.00% 0 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@BubbleCal BubbleCal merged commit f0cc64b into lance-format:main Nov 28, 2025
31 of 34 checks passed
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
resolve lance-format#3398

---------

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamically choose default distance type based on vector type

2 participants