Skip to content

feat: disable default features on internal use #5372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackye1995 merged 3 commits into from
Dec 5, 2025
Merged

feat: disable default features on internal use #5372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56e6101
feat: disable default features on internal uses of crate members
valkum Nov 7, 2025
f82c67b
chore: fix toml formatting
valkum Nov 28, 2025
8f4f649
make sure examples get all features and also support huggingface
jackye1995 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ rust-version = "1.82.0"

[workspace.dependencies]
libc = "0.2.176"
lance = { version = "=1.1.0-beta.2", path = "./rust/lance" }
lance = { version = "=1.1.0-beta.2", path = "./rust/lance", default-features = false }
Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't think we need this?

Copy link
Copy Markdown
Contributor Author

@valkum valkum Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not at my computer right now, but this is the core issue. All crates that use lance inside this workspace will enable the default features of lance.

Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this default-features = false to only lance-namespace-impls? Because examples also depend on lance, and should have the default features enabled so people can try the example in cloud

Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a patch to make examples still have all features, let me know if this looks good

lance-arrow = { version = "=1.1.0-beta.2", path = "./rust/lance-arrow" }
lance-core = { version = "=1.1.0-beta.2", path = "./rust/lance-core" }
lance-datafusion = { version = "=1.1.0-beta.2", path = "./rust/lance-datafusion" }
Expand Down Expand Up @@ -141,7 +141,7 @@ humantime = "2.2.0"
hyperloglogplus = { version = "0.4.1", features = ["const-loop"] }
itertools = "0.13"
jieba-rs = { version = "0.8.1", default-features = false }
jsonb = { version = "0.5.3", default-features = false, features = ["databend"]}
jsonb = { version = "0.5.3", default-features = false, features = ["databend"] }
libm = "0.2.15"
log = "0.4"
mockall = { version = "0.13.1" }
Expand Down
2 changes: 1 addition & 1 deletion rust/examples/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ arrow-select = { workspace = true }
clap = { workspace = true, features = ["derive"] }
itertools = { workspace = true }
futures = { workspace = true }
lance = { workspace = true }
lance = { workspace = true, features = ["aws", "azure", "gcp", "oss", "huggingface"] }
lance-index = { workspace = true }
lance-core = { workspace = true }
lance-linalg = { workspace = true }
Expand Down
13 changes: 7 additions & 6 deletions rust/lance-namespace-impls/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,15 @@ categories.workspace = true
rust-version.workspace = true

[features]
default = []
default = ["dir-aws", "dir-azure", "dir-gcp", "dir-oss", "dir-huggingface"]
rest = ["dep:reqwest"]
rest-adapter = ["dep:axum", "dep:tower", "dep:tower-http", "dep:serde"]
# Cloud storage features for directory implementation - align with lance-io
dir-gcp = ["lance-io/gcp"]
dir-aws = ["lance-io/aws"]
dir-azure = ["lance-io/azure"]
dir-oss = ["lance-io/oss"]
dir-gcp = ["lance-io/gcp", "lance/gcp"]
dir-aws = ["lance-io/aws", "lance/aws"]
dir-azure = ["lance-io/azure", "lance/azure"]
dir-oss = ["lance-io/oss", "lance/oss"]
dir-huggingface = ["lance-io/huggingface", "lance/huggingface"]

[dependencies]
lance-namespace.workspace = true
Expand All @@ -32,7 +33,7 @@ reqwest = { version = "0.12", optional = true, default-features = false, feature
"gzip",
"http2",
"stream",
"rustls-tls-native-roots"
"rustls-tls-native-roots",
] }
# Directory implementation dependencies (always enabled)
url = { workspace = true }
Expand Down
Loading