refactor: consolidate logic between zonemap and bloomfilter indexes#5374
Merged
HaochengLIU merged 12 commits intolance-format:mainfrom Dec 8, 2025
Merged
refactor: consolidate logic between zonemap and bloomfilter indexes#5374HaochengLIU merged 12 commits intolance-format:mainfrom
HaochengLIU merged 12 commits intolance-format:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
Author
|
Hi @HaochengLIU, sorry for the delay—could you take a look at the PR when you have a chance? It consolidates the shared zone logic between ZoneMap and BloomFilter. Happy to address any feedback, thanks! |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Member
|
@fenfeng9 finish the first round of review |
HaochengLIU
requested changes
Dec 4, 2025
Contributor
Author
|
Thanks for the feedback.I'll address these comments and fix the conflicts tomorrow. |
Consolidate duplicated zone training code from zonemap and bloomfilter into a new shared module with ZoneTrainer<P: ZoneProcessor> abstraction. - Add zoned.rs with ZoneBound struct and ZoneProcessor trait - Simplify zonemap and bloomfilter training to use shared trainer
- add search_zones helper (with coverage) and clarify ZoneTrainer contract - switch BloomFilter/ZoneMap indices to the shared search path via ZoneBound::as_ref
fenfeng9
force-pushed
the
refactor/zonemap-bloomfilter
branch
from
fa7c2c5 to
f5dbf47
Compare
Member
|
The PR lgtm. Once all tests pass I'll merge it. Thanks for the contribution! @fenfeng9 |
HaochengLIU
approved these changes
Dec 8, 2025
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…ance-format#5374) Closes lance-format#5230 #### Background ZoneMap and BloomFilter indexes both needed zone training and search capabilities, so this PR factors those shared pieces into a common module that the two indexes now reuse. #### Changes - add `scalar::zoned` with a shared trainer (`ZoneTrainer`/`ZoneProcessor`), `ZoneBound`, `search_zones`, and `rebuild_zones` - migrate the zonemap index to the shared infrastructure so training, updating, and searching all use the common logic - migrate the bloomfilter index the same way to remove duplicated state and ensure consistent row-range handling --------- Co-authored-by: Haocheng Liu <30446009+HaochengLIU@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5230
Background
ZoneMap and BloomFilter indexes both needed zone training and search capabilities, so this PR factors those shared pieces into a common module that the two indexes now reuse.
Changes
scalar::zonedwith a shared trainer (ZoneTrainer/ZoneProcessor),ZoneBound,search_zones, andrebuild_zones