Skip to content

refactor: align with blob v2 logical types change#5375

Merged
Xuanwo merged 2 commits intomainfrom
Xuanwo/blob-v2-rfc-audit
Dec 1, 2025
Merged

refactor: align with blob v2 logical types change#5375
Xuanwo merged 2 commits intomainfrom
Xuanwo/blob-v2-rfc-audit

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Dec 1, 2025

This PR is used to align with blob v2 logical types change


This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rust/lance-encoding/src/encodings/logical/blob.rs
@Xuanwo Xuanwo merged commit c82d18e into main Dec 1, 2025
21 of 24 checks passed
@Xuanwo Xuanwo deleted the Xuanwo/blob-v2-rfc-audit branch December 1, 2025 12:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 3.65854% with 158 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance-encoding/src/encodings/logical/blob.rs 0.00% 128 Missing ⚠️
rust/lance/src/dataset/blob.rs 5.26% 18 Missing ⚠️
rust/lance-encoding/src/encoder.rs 0.00% 12 Missing ⚠️

📢 Thoughts on this report? Let us know!

jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
This PR is used to align with blob v2 logical types change

---

**This PR was primarily authored with Codex using GPT-5-Codex and then
hand-reviewed by me. I AM responsible for every change made in this PR.
I aimed to keep it aligned with our goals, though I may have missed
minor issues. Please flag anything that feels off, I'll fix it
quickly.**

---------

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants