feat(cdf): support set start/end timestamp in cdf#5378
Merged
yanghua merged 10 commits intolance-format:mainfrom Jan 13, 2026
Merged
feat(cdf): support set start/end timestamp in cdf#5378yanghua merged 10 commits intolance-format:mainfrom
yanghua merged 10 commits intolance-format:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
yanghua
approved these changes
Jan 13, 2026
Collaborator
yanghua
left a comment
yanghua
left a comment
There was a problem hiding this comment.
LGTM. It would be better to update the related documentation: https://lance.org/format/table/row_id_lineage/#change-data-feed
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
closes: lance-format#5445 Iterate through versions, find the first version that is greater than or equal to it based on the begin date, and find the last version that is less than it based on the end_date ``` let delta = ds .delta() .with_begin_date(begin_ts) .with_end_date(end_ts) .build() .unwrap(); ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #5445
Iterate through versions, find the first version that is greater than or equal to it based on the begin date, and find the last version that is less than it based on the end_date