fix: avx512 related symbol not found in mac x86#5379
Merged
jackye1995 merged 3 commits intolance-format:mainfrom Dec 2, 2025
Merged
fix: avx512 related symbol not found in mac x86#5379jackye1995 merged 3 commits intolance-format:mainfrom
jackye1995 merged 3 commits intolance-format:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
westonpace
approved these changes
Dec 1, 2025
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Approve the change but I'm not sure I understand the situation that caused the error so I'm not sure I understand if it would be feasible, practical, or useful to ask for some kind of test.
Contributor
Author
|
Tried to verify in lancedb but can't do that without a pypi release. Will merge this first and see if it works. |
This was referenced Dec 2, 2025
jackye1995
added a commit
that referenced
this pull request
Dec 2, 2025
We have very low download stats for mac x86, and also latest github runners for mac are all arm, so it makes sense at this point to deprecate x86 support in general. We also revert #5379 since it is no longer needed.
jackye1995
added a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
related failure in lancedb: https://github.com/lancedb/lancedb/actions/runs/19769925006/job/56653636802?pr=2826 There are two independent AVX-512 builds that both set the same cfg flag kernel_support="avx512": 1. f16 kernels (line 45-56): Uses -march=sapphirerapids - a fixed cross-compilation target 2. dist_table (line 58-64): Uses -march=native - uses the build machine's CPU features Then in dist_table.rs: - Lines 38-48: The AVX-512 code path is compiled (because cfg is set) - Lines 164-171: The extern "C" declaration for sum_4bit_dist_table_32bytes_batch_avx512 is compiled - But the C code was never built, so the symbol doesn't exist Separate cfg flags should be used for f16 and dist_table AVX-512 support
jackye1995
added a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
We have very low download stats for mac x86, and also latest github runners for mac are all arm, so it makes sense at this point to deprecate x86 support in general. We also revert lance-format#5379 since it is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related failure in lancedb: https://github.com/lancedb/lancedb/actions/runs/19769925006/job/56653636802?pr=2826
There are two independent AVX-512 builds that both set the same cfg flag kernel_support="avx512":
Then in dist_table.rs:
Separate cfg flags should be used for f16 and dist_table AVX-512 support