refactor: split dataset tests in a tests mod#5387
Merged
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Signed-off-by: Xuanwo <github@xuanwo.io>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
westonpace
approved these changes
Dec 3, 2025
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Dec 19, 2025
The intention of this PR is to make our codebase a bit more AI-friendly and developer-friendly. It's really hard to scroll through a large file with 10k lines. This PR splits the dataset tests, over 7k LOC, into smaller files to make them easier to find and edit. I'm not sure if it's a good idea, I just put this together and am looking for feedback. --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.1-codex-max`) and fully reviewed and edited by me. I take full responsibility for all changes.** --------- Signed-off-by: Xuanwo <github@xuanwo.io>
wjones127
pushed a commit
that referenced
this pull request
Dec 19, 2025
The intention of this PR is to make our codebase a bit more AI-friendly and developer-friendly. It's really hard to scroll through a large file with 10k lines. This PR splits the dataset tests, over 7k LOC, into smaller files to make them easier to find and edit. I'm not sure if it's a good idea, I just put this together and am looking for feedback. --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.1-codex-max`) and fully reviewed and edited by me. I take full responsibility for all changes.** --------- Signed-off-by: Xuanwo <github@xuanwo.io>
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
The intention of this PR is to make our codebase a bit more AI-friendly and developer-friendly. It's really hard to scroll through a large file with 10k lines. This PR splits the dataset tests, over 7k LOC, into smaller files to make them easier to find and edit. I'm not sure if it's a good idea, I just put this together and am looking for feedback. --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.1-codex-max`) and fully reviewed and edited by me. I take full responsibility for all changes.** --------- Signed-off-by: Xuanwo <github@xuanwo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention of this PR is to make our codebase a bit more AI-friendly and developer-friendly. It's really hard to scroll through a large file with 10k lines. This PR splits the dataset tests, over 7k LOC, into smaller files to make them easier to find and edit.
I'm not sure if it's a good idea, I just put this together and am looking for feedback.
Parts of this PR were drafted with assistance from Codex (with
gpt-5.1-codex-max) and fully reviewed and edited by me. I take full responsibility for all changes.